OCPCLOUD-3420: Remove exceptions OCPBUGS-42837 and OCPBUGS-64852 by hongkailiu · Pull Request #31469 · openshift/origin

hongkailiu · 2026-08-01T11:57:29Z

They are fixed in 5.0.

/hold

wait for 5.1 cut.

Summary by CodeRabbit

Bug Fixes
- Operator transition checks now correctly report SyncingFailed conditions without treating the cloud controller manager as an exception.
- Applied consistently across stable, upgrade, and progressing-state checks.

They are fixed in 5.0. * https://redhat.atlassian.net/browse/OCPBUGS-42837?focusedCommentId=17817891 * https://redhat.atlassian.net/browse/OCPBUGS-64852?focusedCommentId=17817896

openshift-merge-bot · 2026-08-01T11:57:31Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci · 2026-08-01T11:57:33Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

coderabbitai · 2026-08-01T11:58:52Z

Walkthrough

The change removes the cloud-controller-manager SyncingFailed exception from stable, upgrade, and progressing-state transition checks.

Changes

Cluster version operator transition checks

Layer / File(s)	Summary
Remove transition exceptions `pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go`	Stable, upgrade, and progressing-state checks no longer exempt `cloud-controller-manager` `SyncingFailed` conditions.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The patch only removes three exception branches. It adds no test titles, and existing JUnit names use stable operator and condition identifiers rather than run-generated values.
Test Structure And Quality	✅ Passed	The commit only removes three exception branches. The changed file generates JUnit cases from events and has no Ginkgo It blocks, resource creation, cleanup, Eventually, or Consistently calls.
Microshift Test Compatibility	✅ Passed	The PR only deletes nine existing exception branches in operators.go; it adds no Ginkgo tests or new API/feature references, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request only deletes three exception blocks from operators.go; it adds no new Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The only change is in a monitor-test file and removes three SyncingFailed exceptions; it adds no manifests, controllers, replicas, affinity, selectors, tolerations, or topology constraints.
Ote Binary Stdout Contract	✅ Passed	The commit only deletes three exception blocks; it adds no main/init/suite setup, stdout writes, klog calls, or logging configuration changes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit only deletes three exception blocks from operators.go; it adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The commit only deletes three operator-condition exception branches; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret-comparison code.
Container-Privileges	✅ Passed	The PR changes only nine deleted lines in a Go monitor test. The diff adds no container or Kubernetes manifest privilege settings.
No-Sensitive-Data-In-Logs	✅ Passed	The parent-to-HEAD diff contains only nine deleted exception lines and adds no logging or sensitive-data output.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the removal of the two exceptions, which matches the primary change described in the pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

openshift-merge-bot · 2026-08-01T13:14:39Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

hongkailiu · 2026-08-04T20:23:43Z

/retest-required

hongkailiu · 2026-08-04T21:39:41Z

/retest-required

hongkailiu · 2026-08-04T21:41:44Z

/cc @nrb @theobarberbany

/uncc @p0lyn0mial @sjenning

hongkailiu · 2026-08-11T12:19:20Z

/test e2e-metal-ipi-ovn-ipv6

hongkailiu · 2026-08-11T12:27:22Z

Checked Sippy 5.0 today.
See the comments in the bugs.
They all look good me.

/verified by @hongkailiu

openshift-ci-robot · 2026-08-11T12:27:33Z

@hongkailiu: This PR has been marked as verified by @hongkailiu.

Details

In response to this:

Checked Sippy 5.0 today.
See the comments in the bugs.
They all look good me.

/verified by @hongkailiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

theobarberbany · 2026-08-11T12:35:23Z

/lgtm
/approve

openshift-ci · 2026-08-11T14:25:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, petr-muller, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-08-11T16:38:12Z

@hongkailiu: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-08-11T16:45:37Z

@hongkailiu: This pull request references OCPCLOUD-3420 which is a valid jira issue.

Details

In response to this:

They are fixed in 5.0.

https://redhat.atlassian.net/browse/OCPBUGS-42837?focusedCommentId=17817891

https://redhat.atlassian.net/browse/OCPBUGS-64852?focusedCommentId=17817896

/hold

wait for 5.1 cut.

Summary by CodeRabbit

Bug Fixes

Operator transition checks now correctly report SyncingFailed conditions without treating the cloud controller manager as an exception.

Applied consistently across stable, upgrade, and progressing-state checks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

hongkailiu · 2026-08-11T16:45:48Z

/jira refresh

openshift-ci-robot · 2026-08-11T16:45:51Z

@hongkailiu: This pull request references OCPCLOUD-3420 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Remove exceptions OCPBUGS-42837 and OCPBUGS-64852

96a8571

They are fixed in 5.0. * https://redhat.atlassian.net/browse/OCPBUGS-42837?focusedCommentId=17817891 * https://redhat.atlassian.net/browse/OCPBUGS-64852?focusedCommentId=17817896

openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 1, 2026

hongkailiu marked this pull request as ready for review August 1, 2026 11:58

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2026

openshift-ci Bot requested review from p0lyn0mial and sjenning August 1, 2026 11:58

coderabbitai Bot approved these changes Aug 1, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 1, 2026

openshift-ci Bot requested review from nrb and theobarberbany and removed request for p0lyn0mial and sjenning August 4, 2026 21:41

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 11, 2026

openshift-ci Bot assigned theobarberbany Aug 11, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026

petr-muller approved these changes Aug 11, 2026

View reviewed changes

openshift-ci Bot assigned petr-muller Aug 11, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2026

hongkailiu changed the title ~~Remove exceptions OCPBUGS-42837 and OCPBUGS-64852~~ OCPCLOUD-3420: Remove exceptions OCPBUGS-42837 and OCPBUGS-64852 Aug 11, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 11, 2026

Uh oh!

Conversation

hongkailiu commented Aug 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Aug 1, 2026

Uh oh!

openshift-ci Bot commented Aug 1, 2026

Uh oh!

coderabbitai Bot commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

openshift-merge-bot Bot commented Aug 1, 2026

Uh oh!

hongkailiu commented Aug 4, 2026

Uh oh!

hongkailiu commented Aug 4, 2026

Uh oh!

hongkailiu commented Aug 4, 2026

Uh oh!

hongkailiu commented Aug 11, 2026

Uh oh!

hongkailiu commented Aug 11, 2026

Uh oh!

openshift-ci-robot commented Aug 11, 2026

Uh oh!

theobarberbany commented Aug 11, 2026

Uh oh!

openshift-ci Bot commented Aug 11, 2026

Uh oh!

openshift-ci Bot commented Aug 11, 2026

Uh oh!

openshift-ci-robot commented Aug 11, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

hongkailiu commented Aug 11, 2026

Uh oh!

openshift-ci-robot commented Aug 11, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hongkailiu commented Aug 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 1, 2026 •

edited

Loading

openshift-ci-robot commented Aug 11, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Aug 11, 2026 •

edited by openshift-ci Bot

Loading